Skip to content

[bgen] Handle [DesignatedInitializer] being in two places at once. Fixes #10106. - #23940

Merged
rolfbjarne merged 2 commits into
mainfrom
dev/rolf/issue-10106-designated-initializer
Oct 8, 2025
Merged

[bgen] Handle [DesignatedInitializer] being in two places at once. Fixes #10106.#23940
rolfbjarne merged 2 commits into
mainfrom
dev/rolf/issue-10106-designated-initializer

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

We have the DesignatedInitializer attribute class in two places:

  • Binding attribute assembly.
  • Platform assembly.

And they're in different namespaces too.

This resulted in confusion in the generator, so fix that.

Also remove the version in the binding attribute assembly for XAMCORE_5_0,
since we only need one version.

Fixes #10106.

rolfbjarne and others added 2 commits October 7, 2025 13:01
 #10106.

We have the DesignatedInitializer attribute class in two places:

* Binding attribute assembly.
* Platform assembly.

And they're in different namespaces too.

This resulted in confusion in the generator, so fix that.

Also remove the version in the binding attribute assembly for XAMCORE_5_0,
since we only need one version.

Fixes #10106.
@rolfbjarne
rolfbjarne enabled auto-merge (squash) October 7, 2025 11:24
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… [CI Build #bea4723] Build passed (Build packages) βœ…

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… [PR Build #bea4723] Build passed (Detect API changes) βœ…

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… API diff for current PR / commit

NET (empty diffs)

βœ… API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… [CI Build #bea4723] Build passed (Build macOS tests) βœ…

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #bea4723] Tests on macOS X64 - Mac Sonoma (14) passed πŸ’»

βœ… All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #bea4723] Tests on macOS arm64 - Mac Sequoia (15) passed πŸ’»

βœ… All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #bea4723] Tests on macOS arm64 - Mac Tahoe (26) passed πŸ’»

βœ… All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #bea4723] Tests on macOS M1 - Mac Ventura (13) passed πŸ’»

βœ… All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #bea4723] Tests on macOS M1 - Mac Monterey (12) passed πŸ’»

βœ… All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸš€ [CI Build #bea4723] Test results πŸš€

Test results

βœ… All tests passed on VSTS: test results.

πŸŽ‰ All 126 tests passed πŸŽ‰

Tests counts

βœ… cecil: All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… framework: All 2 tests passed. Html Report (VSDrops) Download
βœ… fsharp: All 4 tests passed. Html Report (VSDrops) Download
βœ… generator: All 5 tests passed. Html Report (VSDrops) Download
βœ… interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
βœ… introspection: All 6 tests passed. Html Report (VSDrops) Download
βœ… linker: All 44 tests passed. [attempt 3] Html Report (VSDrops) Download
βœ… monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
βœ… monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
βœ… monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
βœ… monotouch (tvOS): All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
βœ… msbuild: All 2 tests passed. Html Report (VSDrops) Download
βœ… windows: All 3 tests passed. Html Report (VSDrops) Download
βœ… xcframework: All 4 tests passed. Html Report (VSDrops) Download
βœ… xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: bea4723c4db11c097b7103e3a542c39cd12e4d17 [PR build]

@rolfbjarne
rolfbjarne merged commit 36fabde into main Oct 8, 2025
41 checks passed
@rolfbjarne
rolfbjarne deleted the dev/rolf/issue-10106-designated-initializer branch October 8, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IOS Bindings Library returns an Internal error when try to build the project

3 participants