Skip to content

[msbuild] Ensure all resources are available on Windows before packing them. Fixes #23928. - #23971

Merged
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/issue-23928-copy-resources-from-mac-to-windows-before-packing
Oct 10, 2025
Merged

[msbuild] Ensure all resources are available on Windows before packing them. Fixes #23928.#23971
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/issue-23928-copy-resources-from-mac-to-windows-before-packing

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

Library projects might compile resources on the Mac before those compiled
resources are embedded into the resulting assembly.

However, some tasks will only create a 0-length stamp/output file on Windows,
and we don't want to embed those 0-length files into the assembly.

So if we find any such 0-length files, then copy them from the Mac to Windows
before packing them.

Fixes #23928.

…g them. Fixes #23928.

Library projects might compile resources on the Mac before those compiled
resources are embedded into the resulting assembly.

However, some tasks will only create a 0-length stamp/output file on Windows,
and we don't want to embed those 0-length files into the assembly.

So if we find any such 0-length files, then copy them from the Mac to Windows
before packing them.

Fixes #23928.
@rolfbjarne
rolfbjarne requested review from emaf and mauroa as code owners October 9, 2025 22:43
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… [CI Build #0955951] Build passed (Build packages) βœ…

Pipeline on Agent
Hash: 09559517688e2ab274cef0f66019b494fb011f7c [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… [PR Build #0955951] Build passed (Detect API changes) βœ…

Pipeline on Agent
Hash: 09559517688e2ab274cef0f66019b494fb011f7c [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… API diff for current PR / commit

NET (empty diffs)

βœ… API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 09559517688e2ab274cef0f66019b494fb011f7c [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… [CI Build #0955951] Build passed (Build macOS tests) βœ…

Pipeline on Agent
Hash: 09559517688e2ab274cef0f66019b494fb011f7c [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #0955951] Tests on macOS X64 - Mac Sonoma (14) passed πŸ’»

βœ… All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 09559517688e2ab274cef0f66019b494fb011f7c [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #0955951] Tests on macOS arm64 - Mac Sequoia (15) passed πŸ’»

βœ… All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 09559517688e2ab274cef0f66019b494fb011f7c [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #0955951] Tests on macOS M1 - Mac Ventura (13) passed πŸ’»

βœ… All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 09559517688e2ab274cef0f66019b494fb011f7c [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #0955951] Tests on macOS arm64 - Mac Tahoe (26) passed πŸ’»

βœ… All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 09559517688e2ab274cef0f66019b494fb011f7c [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne
rolfbjarne enabled auto-merge (squash) October 10, 2025 09:22
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #0955951] Tests on macOS M1 - Mac Monterey (12) passed πŸ’»

βœ… All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 09559517688e2ab274cef0f66019b494fb011f7c [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸš€ [CI Build #0955951] Test results πŸš€

Test results

βœ… All tests passed on VSTS: test results.

πŸŽ‰ All 128 tests passed πŸŽ‰

Tests counts

βœ… cecil: All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… framework: All 2 tests passed. Html Report (VSDrops) Download
βœ… fsharp: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
βœ… generator: All 5 tests passed. [attempt 2] Html Report (VSDrops) Download
βœ… interdependent-binding-projects: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
βœ… introspection: All 6 tests passed. [attempt 2] Html Report (VSDrops) Download
βœ… linker: All 44 tests passed. Html Report (VSDrops) Download
βœ… monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
βœ… monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
βœ… monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
βœ… monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
βœ… msbuild: All 2 tests passed. Html Report (VSDrops) Download
βœ… windows: All 3 tests passed. Html Report (VSDrops) Download
βœ… xcframework: All 4 tests passed. Html Report (VSDrops) Download
βœ… xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 09559517688e2ab274cef0f66019b494fb011f7c [PR build]

@rolfbjarne
rolfbjarne merged commit 21c98ab into main Oct 10, 2025
45 checks passed
@rolfbjarne
rolfbjarne deleted the dev/rolf/issue-23928-copy-resources-from-mac-to-windows-before-packing branch October 10, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NSInternalInconsistencyException Reason: (null) when xib files exist in a second iOS library project

3 participants