Skip to content

[msbuild] Fix the PropertyListEditor task to correctly handle two input files. Fixes #24091. - #24105

Merged
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/issue-24091-propertylisteditor
Oct 27, 2025
Merged

[msbuild] Fix the PropertyListEditor task to correctly handle two input files. Fixes #24091.#24105
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/issue-24091-propertylisteditor

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

Fix the PropertyListEditor task to not only check for null input, but also
empty empty - this fixes an regression where we changed the default property
value for the task inputs from null to an empty string, and then any null
checks later on would fail.

Fixes #24091.

…ut files. Fixes #24091.

Fix the PropertyListEditor task to not only check for null input, but also
empty empty - this fixes an regression where we changed the default property
value for the task inputs from null to an empty string, and then any null
checks later on would fail.

Fixes #24091.
@rolfbjarne rolfbjarne changed the title [msbuild] Fix the PropertyListEditor task to correclty handle two input files. Fixes #24091. [msbuild] Fix the PropertyListEditor task to correctly handle two input files. Fixes #24091. Oct 27, 2025
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… [CI Build #dc05811] Build passed (Build packages) βœ…

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… [PR Build #dc05811] Build passed (Detect API changes) βœ…

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… API diff for current PR / commit

NET (empty diffs)

βœ… API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… [CI Build #dc05811] Build passed (Build macOS tests) βœ…

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #dc05811] Tests on macOS X64 - Mac Sonoma (14) passed πŸ’»

βœ… All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #dc05811] Tests on macOS M1 - Mac Monterey (12) passed πŸ’»

βœ… All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #dc05811] Tests on macOS M1 - Mac Ventura (13) passed πŸ’»

βœ… All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #dc05811] Tests on macOS arm64 - Mac Tahoe (26) passed πŸ’»

βœ… All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build #dc05811] Tests on macOS arm64 - Mac Sequoia (15) passed πŸ’»

βœ… All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne
rolfbjarne enabled auto-merge (squash) October 27, 2025 18:27
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸš€ [CI Build #dc05811] Test results πŸš€

Test results

βœ… All tests passed on VSTS: test results.

πŸŽ‰ All 119 tests passed πŸŽ‰

Tests counts

βœ… cecil: All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… framework: All 2 tests passed. Html Report (VSDrops) Download
βœ… fsharp: All 4 tests passed. Html Report (VSDrops) Download
βœ… generator: All 5 tests passed. Html Report (VSDrops) Download
βœ… interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
βœ… introspection: All 4 tests passed. Html Report (VSDrops) Download
βœ… linker: All 44 tests passed. Html Report (VSDrops) Download
βœ… monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
βœ… monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
βœ… monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
βœ… monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
βœ… msbuild: All 2 tests passed. Html Report (VSDrops) Download
βœ… windows: All 3 tests passed. Html Report (VSDrops) Download
βœ… xcframework: All 4 tests passed. [attempt 3] Html Report (VSDrops) Download
βœ… xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: dc05811f0cf6a33da052a7b71033af3d741d9fc9 [PR build]

@rolfbjarne
rolfbjarne merged commit ef864de into main Oct 27, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PropertyListEditor.Entry defaulted to string.Empty

5 participants