Skip to content

Field doesn't need to be volatile #47225

Closed
#48277
Closed
Field doesn't need to be volatile#47225
#48277
Labels
Area-IDEBugFeature - IDE0044Make field readonlyResolution-FixedThe bug has been fixed and/or the requested behavior has been implemented
Milestone
Backlog

Description

@Youssef1313
Youssef1313
opened on Aug 28, 2020

IDE0044 suggests the field to be readonly, which can't be used together with volatile.

roslyn/src/Scripting/CoreTestUtilities/ObjectFormatterFixtures/MockDesktopSpinLock.cs

Line 18 in 3dc1532

private volatile int m_owner;

It seems reasonable that volatile can be omitted. The field is only set in the constructor. How can multiple threads modify it?

Activity

  1. gafter
    added
    Area-IDE
    on Aug 30, 2020
  2. jinujoseph
    added
    Bug
    help wantedThe issue is "up for grabs" - add a comment if you are interested in working on it
    on Sep 7, 2020
  3. jinujoseph
    assigned
    mavasani
    on Sep 7, 2020
  4. jinujoseph
    added this to the Backlog milestone on Sep 7, 2020
  5. mavasani
    removed their assignment
    on Sep 22, 2020

  6. huoyaoyuan commented on Oct 3, 2020

    @huoyaoyuan
    huoyaoyuan
    on Oct 3, 2020
    Member

    Already fixed by #43542 .

  7. mavasani
    closed this as completedin #48277on Oct 17, 2020
  8. sharwell
    added
    Resolution-FixedThe bug has been fixed and/or the requested behavior has been implemented
    Feature - IDE0044Make field readonly
    and removed
    help wantedThe issue is "up for grabs" - add a comment if you are interested in working on it
    on May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-IDEBugFeature - IDE0044Make field readonlyResolution-FixedThe bug has been fixed and/or the requested behavior has been implemented

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions