Repository navigation
implement remove 'Shared' from VB module members codefix - #48289
Merged
CyrusNajmabadi merged 7 commits intoOct 16, 2020
Merged
Conversation
Youssef1313
marked this pull request as draft
October 3, 2020 21:19
Youssef1313
marked this pull request as ready for review
October 3, 2020 21:22
Youssef1313
force-pushed
the
codefix-remove-shared-vb-module
branch
from
October 3, 2020 21:22
9a3b332 to
5b18032
Compare
This was referenced Oct 5, 2020
Closed
jinujoseph
added
Area-IDE
Community
Comment on lines
+63
to
+64
| Dim tokenToRemove = diagnostic.Location.FindToken(cancellationToken) | ||
| Dim node = diagnostic.Location.FindNode(cancellationToken) |
Member
There was a problem hiding this comment.
Does this need the same checks as in the RegisterCodeFixesAsync?
Member
Author
There was a problem hiding this comment.
@jasonmalinowski I don't have a 100% understanding of the code flow, but my assumption is that if the check failed in RegisterCodeFixesAsync, then FixAllAsync won't be called with this bad input.
Member
Author
|
Is there anything left for this? @CyrusNajmabadi @jasonmalinowski |
|
|
||
| Protected Overrides Function FixAllAsync(document As Document, diagnostics As ImmutableArray(Of Diagnostic), editor As SyntaxEditor, cancellationToken As CancellationToken) As Task | ||
| For Each diagnostic In diagnostics | ||
| Dim tokenToRemove = diagnostic.Location.FindToken(cancellationToken) |
Contributor
There was a problem hiding this comment.
this valid seems unused.
Contributor
|
done with pass. |
Youssef1313
commented
Oct 12, 2020
CyrusNajmabadi
approved these changes
Oct 12, 2020
Member
Author
|
There is an unrelated integration test failure. @CyrusNajmabadi Can you re-run the failed job? Thanks. |
Contributor
|
Done! |
ghost
added this to the
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45163