Repository navigation
Support NotNullIfNotNull in user-defined binary operators - #48490
Merged
Merged
Conversation
RikkiGibson
added
Area-Compilers
Community
RikkiGibson
reviewed
Oct 12, 2020
| (c1 / c2).ToString(); // no warn | ||
| (c1 / cn2).ToString(); // warn | ||
| (cn1 / c2).ToString(); // no warn | ||
| (cn1 / cn2).ToString(); // warn |
Member
There was a problem hiding this comment.
Could you please add a test that verifies expected behavior around +=/-=/*=//= with these operators? Both the nullable state of the expression and the nullable state of the LHS of the assignment.
#Closed
Contributor
Author
There was a problem hiding this comment.
Test added. Let me know, if you still find some missing coverage. #Closed
RikkiGibson
approved these changes
Oct 12, 2020
Member
|
@dotnet/roslyn-compiler for senior review |
Member
|
@dotnet/roslyn-compiler Please review |
ghost
added this to the
Contributor
|
Thanks @duracellko! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48489
This implements
NotNullIfNotNullattribute on return type of user defined binary operators.