Skip to content

Do not cast when refactoring 'foreach var' - #49120

Merged
mavasani merged 2 commits into
dotnet:masterfrom
huoyaoyuan:foreach-var
Nov 30, 2020
Merged

mavasani merged 2 commits into
dotnet:masterfrom
huoyaoyuan:foreach-var

Conversation

@huoyaoyuan

Copy link
Copy Markdown
Member

Fixes #48950. Replaces #49100.

Not bothering so much - just testing the most common case.

@huoyaoyuan

Copy link
Copy Markdown
Member Author

Out of time failure :(

@huoyaoyuan huoyaoyuan closed this Nov 2, 2020
@huoyaoyuan huoyaoyuan reopened this Nov 2, 2020
@jinujoseph jinujoseph added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Nov 2, 2020
@mavasani
mavasani merged commit 195cc4b into dotnet:master Nov 30, 2020
@ghost ghost added this to the Next milestone Nov 30, 2020
@huoyaoyuan
huoyaoyuan deleted the foreach-var branch December 1, 2020 06:44
@dibarbet dibarbet modified the milestones: Next, 16.9.P3 Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Analyzers Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't cast when converting foreach loop to for loop unless necessary

5 participants