Skip to content

Fix check method for ffmpeg vaapi support - #232

Merged
elFarto merged 1 commit into
elFarto:masterfrom
q234rty:master-1
Aug 13, 2023
Merged

elFarto merged 1 commit into
elFarto:masterfrom
q234rty:master-1

Conversation

@q234rty

@q234rty q234rty commented Aug 10, 2023

Copy link
Copy Markdown
Contributor

The switch --enable-vaapi does not exist in ffmpeg upstream's configure script. Instead there's a --disable-vaapi switch.

FFmpeg autodetects whether vaapi support should be enabled by default, and the proper way to check for that at runtime is ffmpeg -hwaccels.

On my Arch Linux system, with extra/ffmpeg 2:6.0-8:

$ ffmpeg -hwaccels 
ffmpeg version n6.0 Copyright (c) 2000-2023 the FFmpeg developers
  built with gcc 13.1.1 (GCC) 20230429
  configuration: --prefix=/usr --disable-debug --disable-static --disable-stripping --enable-amf --enable-avisynth --enable-cuda-llvm --enable-lto --enable-fontconfig --enable-gmp --enable-gnutls --enable-gpl --enable-ladspa --enable-libaom --enable-libass --enable-libbluray --enable-libbs2b --enable-libdav1d --enable-libdrm --enable-libfreetype --enable-libfribidi --enable-libgsm --enable-libiec61883 --enable-libjack --enable-libjxl --enable-libmfx --enable-libmodplug --enable-libmp3lame --enable-libopencore_amrnb --enable-libopencore_amrwb --enable-libopenjpeg --enable-libopenmpt --enable-libopus --enable-libpulse --enable-librav1e --enable-librsvg --enable-libsoxr --enable-libspeex --enable-libsrt --enable-libssh --enable-libsvtav1 --enable-libtheora --enable-libv4l2 --enable-libvidstab --enable-libvmaf --enable-libvorbis --enable-libvpx --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxcb --enable-libxml2 --enable-libxvid --enable-libzimg --enable-nvdec --enable-nvenc --enable-opencl --enable-opengl --enable-shared --enable-version3 --enable-vulkan
  libavutil      58.  2.100 / 58.  2.100
  libavcodec     60.  3.100 / 60.  3.100
  libavformat    60.  3.100 / 60.  3.100
  libavdevice    60.  1.100 / 60.  1.100
  libavfilter     9.  3.100 /  9.  3.100
  libswscale      7.  1.100 /  7.  1.100
  libswresample   4. 10.100 /  4. 10.100
  libpostproc    57.  1.100 / 57.  1.100
Hardware acceleration methods:
vdpau
cuda
vaapi
qsv
drm
opencl
vulkan

Note how there's no --enable-vaapi in the above output.

@sontjer

sontjer commented Aug 10, 2023 •

Copy link
Copy Markdown

I can confirm that, mine is nvidia with ffmpeg with nvidia drivers properly installed, no --enable-vaapi from output results.

@elFarto

elFarto commented Aug 13, 2023

Copy link
Copy Markdown
Owner

Thanks for the patch!

@elFarto
elFarto merged commit 59aecf1 into elFarto:master Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants