Skip to content

EIP 34 - open log in new tab - #192

Merged
jonherrmann merged 2 commits into
etf-validator:nextfrom
guadaltel:EIP-34
Apr 3, 2019
Merged

jonherrmann merged 2 commits into
etf-validator:nextfrom
guadaltel:EIP-34

Conversation

@carlospzurita

Copy link
Copy Markdown
Contributor

Fixing for etf-validator/governance#34
We added a target="_blank" on the test-reports.html to make the log create a new tab on the browser

Signed-off-by: Carlos Palma <carlospalma@guadaltel.com>
@jonherrmann
jonherrmann self-requested a review February 15, 2019 09:50
@jonherrmann jonherrmann changed the title EIP 34 EIP 34 - open log in new tab Apr 3, 2019
@jonherrmann
jonherrmann merged commit 2db6282 into etf-validator:next Apr 3, 2019
@carlospzurita
carlospzurita deleted the EIP-34 branch May 15, 2019 16:03
@jonherrmann jonherrmann added the PR: ignore used to filter rejected / reopened Pull Requests label Jul 31, 2020
@jonherrmann

jonherrmann commented Jul 31, 2020 •

Copy link
Copy Markdown
Collaborator

Ignoring the PRs code for release 2.1.0 in favour of target="<%= testRun.id %>".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: ignore used to filter rejected / reopened Pull Requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants