Skip to content

eth,node: replace the deprecated TypeMux with Feed - #32585

Merged
rjl493456442 merged 7 commits into
ethereum:masterfrom
jsvisa:remove-event-mux
May 8, 2026
Merged

rjl493456442 merged 7 commits into
ethereum:masterfrom
jsvisa:remove-event-mux

Conversation

@jsvisa

@jsvisa jsvisa commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

replace the not used event.Typemux to event.Feed

@jsvisa jsvisa changed the title all: replace the deprecated TypeMux with Feed eth,node: replace the deprecated TypeMux with Feed Sep 11, 2025
Comment thread eth/downloader/downloader.go Resolved
@jsvisa
jsvisa requested a review from fjl September 13, 2025 02:30
@rjl493456442 rjl493456442 self-assigned this Sep 24, 2025
@fjl fjl self-assigned this Nov 26, 2025
@fjl
fjl force-pushed the remove-event-mux branch from 510074d to 5f4ac67 Compare April 29, 2026 14:01
@fjl fjl added this to the 1.17.3 milestone Apr 29, 2026
@fjl fjl removed their assignment May 7, 2026
@rjl493456442
rjl493456442 merged commit 1abbae2 into ethereum:master May 8, 2026
9 checks passed
@jsvisa
jsvisa deleted the remove-event-mux branch May 8, 2026 03:43
diega added a commit to go-ethereum-classic/go-ethereum-classic that referenced this pull request May 12, 2026
Reintroduce PoW (TD-based, peer-driven) sync path. Upstream's downloader
was rewritten in PR ethereum#29281 to assume PoS (beacon-driven). For ETC the
downloader needs to:

- Drive sync from peer TD comparisons (downloader_pow.go).
- Publish SyncEvent (Started/Failed/Completed) via the new feed-based
  SubscribeSyncEvents API; the legacy TypeMux events that were removed
  in PR ethereum#32585 no longer apply.
- Concurrent header fetcher and queue specialised for PoW (no skeleton,
  no beacon hints) live in fetchers_concurrent_headers_pow.go and
  queue_pow.go.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
diega added a commit to go-ethereum-classic/go-ethereum-classic that referenced this pull request May 12, 2026
Reintroduce PoW (TD-based, peer-driven) sync path. Upstream's downloader
was rewritten in PR ethereum#29281 to assume PoS (beacon-driven). For ETC the
downloader needs to:

- Drive sync from peer TD comparisons (downloader_pow.go).
- Publish SyncEvent (Started/Failed/Completed) via the new feed-based
  SubscribeSyncEvents API; the legacy TypeMux events that were removed
  in PR ethereum#32585 no longer apply.
- Concurrent header fetcher and queue specialised for PoW (no skeleton,
  no beacon hints) live in fetchers_concurrent_headers_pow.go and
  queue_pow.go.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants