Repository navigation
ethclient: add maxUsedGas to simulate call results - #34820
Merged
Merged
Conversation
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 30, 2026
3 of 25 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 30, 2026
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jul 6, 2026
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jul 9, 2026
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the typed
ethclientmodel foreth_simulateV1call results to includemaxUsedGas, matching the field already returned by the server-side RPC response.The generated JSON codec now marshals and unmarshals
maxUsedGasas a hex quantity, andTestSimulateV1checks that the field is populated through the client path.Follow-up to #32789.