[BUG] Foot terminalfont doesn't parse font sizes using Font Name-size syntax #2624

Read the FAQ first

• I have checked the FAQ but the issue is not covered

Description

Foot takes fonts as raw comma-separated strings to pass to fontconfig. Its current ad-hoc parser only detects the Font Name:size=n syntax, but fontconfig also lets you write size as Font Name-n, which works fine in foot confuses fastfetch. For instance, with foot.ini font=Berkeley Mono-12, fastfetch shows Terminal Font: Berkeley Mono-12 (8pt).

Since fastfetch now has a ffFontInitXft function, I propose foot's parser be moved to that, as well as st's, which is probably the more "correct" option (catching stuff like pixelsize) and should deduplicate some code. One possible caveat I should mention though is that they handle commas differently. Foot splits the string on commas to specify fallbacks before handing them to fontconfig AFAIK, whereas st just hands over the whole string and lets fontconfig split just the family, so for instance A,B:size=12 would mean completely different thing on foot and st.

Version used

2.69.0

Bug prevalence

Always

Regression

No

Installation

Built from source

Package manager

No response

Screenshots

No response

Configuration

System information

.

Features built-in

linux-headers 7.1.0
threads
libzfs
linux/videodev2
Embedded wcwidth