Skip to content

Fix the FUSE CLI foreground option - #2352

Merged
martindurant merged 2 commits into
fsspec:masterfrom
tongwentao:fix/fuse-foreground-cli-1586
Oct 21, 2026
Merged

martindurant merged 2 commits into
fsspec:masterfrom
tongwentao:fix/fuse-foreground-cli-1586

Conversation

@tongwentao

Copy link
Copy Markdown
Contributor

Fixes #1586.

The FUSE CLI currently enables foreground mode without -f, and disables it when -f or --foreground is supplied. Use store_true so the option matches its name and documented background default. The Python run() API keeps its existing foreground default.

Add three CLI-to-run() regression cases and an API-default control. The existing local-mount fixture now passes -f explicitly to keep its mount process in the foreground.

Validation on Linux/Python 3.12.13:

  • Original implementation: 3 foreground regressions failed; API-default control passed.
  • pytest fsspec/tests/test_fuse.py -q: 8 passed, including the existing real FUSE mount/read/write/chmod/seek tests.
  • Core, spec, API, memory and local suites: 912 passed, 35 skipped, 2 xfailed. One multiprocessing/fork deprecation warning was emitted.
  • pre-commit run --all-files: passed all applicable hooks, including pinned Ruff 0.14.3.
  • Full optional-backend and downstream suites were not run.

Prepared with OpenAI Codex assistance for the implementation, tests and local verification.

@martindurant
martindurant merged commit b079ca5 into fsspec:master Oct 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fsspec.fuse -f is inverted and hangs when specified

2 participants