Repository navigation
[log] Add debug logging to GraphQL root field parsing - #15538
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
🔒 mcpg Read-Only Stress — defaultSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: INCONCLUSIVE Notes:
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The logging-only additions use side-effect-free arguments, preserve existing behavior, and introduce no identified blocking issues.
No open issues 🎉
What changed in this PR
Adds diagnostic logging to the proxy’s GraphQL root-field parser without changing parsing behavior or return values.
Changes:
- Logs each early-return path using the existing
logGraphQLlogger. - Logs successful root-field counts and names without including query text.
| File | Description |
|---|---|
internal/proxy/graphql.go |
Adds diagnostics for parsing failures and successful root-field extraction. |
Review effort: Max
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds debug log calls (reusing existing
logGraphQL) tographqlRootFieldsininternal/proxy/graphql.go, covering each early-return path (parse failure, ambiguous/duplicate/missing operation, non-query operation, operation text extraction failure) and the successful parse result.Log arguments are side-effect free and don't include query text.
Validation:
go vet ./internal/proxy,go test ./internal/proxy, andgo buildpass.