Repository navigation
Add gojq resource-exhaustion cancellation coverage - #15563
Merged
Merged
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review gojq module for compliance and best practices
Add gojq resource-exhaustion cancellation coverage
Oct 26, 2026
lpcox
marked this pull request as ready for review
October 26, 2026 13:37
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new error assertions conflict with the enabled testifylint require-error rule and would fail CI.
1 open issue
What changed in this PR
Adds regression coverage for gojq resource-exhaustion cancellation in the middleware, addressing #15557 without changing production code or dependencies.
Changes:
- Tests billion-element range reduction and infinite recursion under caller deadlines and cancellation.
- Covers the default timeout, wrapped context-error identity, and preservation of the caller’s context.
| File | Description |
|---|---|
internal/middleware/jqschema_cancellation_test.go |
Adds table-driven cancellation and timeout contract tests. |
Review effort: Max
Collaborator
|
@copilot address review feedback |
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Contributor
Author
Updated the cancellation test to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The gojq review identified missing coverage for pathological filters interrupted during execution. Existing timeout handling needs no production changes or dependency upgrade.