[Copilot]

When concurrency cancellation occurs before the engine starts, the collector reports agent_startup_failure, causing a failure issue for a superseded run.

• Cancellation handling: Extend the existing missing_terminal_safe_output exemption to collector-reported agent_startup_failure, excluding synthetic diagnostics from mixed-output reports.
• Preserved behavior: Continue reporting independent failures, non-cancelled startup failures, and agent-authored incomplete reports without collector corroboration.
• Regression coverage: Extend cancellation and failure-classification cases to cover startup failures.

• Fixes Agent jobs cancelled by engine.concurrency.cancel-in-progress before the engine starts are reported as agent_startup_failure #72367

[github-actions]

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · opus55 · ~11 AIC · ⌖ ~33 AIC · ◇ ~3 AIC · ⊞ 1.9K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

[github-actions]

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

[github-actions]

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · haiku45 · ~6 AIC · ⌖ ~7 AIC · ◇ ~2 AIC · ⊞ 8.8K · ◷

🧪 Test quality analysis by Test Quality Sentinel

[github-actions]

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

[github-actions]

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · gpt56 · ~9 AIC · ⌖ ~6 AIC · ⊞ 14.8K · ◷

Generated by Ponytail Reviewer for #72405

[Copilot]

🟡 Changes recommended

The exemption also suppresses genuine setup failures caused by job-level timeouts.

1 open issue

• Do not suppress setup timeouts with cancelled job results · New

What changed in this PR

This PR extends gh-aw’s conclusion-stage failure handling to suppress collector-reported startup failures when agent jobs are cancelled before execution, addressing #72367.

Changes:

• Applies the cancellation exemption to agent_startup_failure, including mixed-output diagnostics.
• Expands regression cases for cancellation suppression and preserved failure reporting.

File	Description
actions/​setup/​js/​handle_agent_failure.test.cjs	Extends cancellation and failure-classification test cases.
actions/​setup/​js/​handle_agent_failure.cjs	Adds startup failures to the collector-backed cancellation exemption.

_{Review effort: Max}

[github-actions]

Comment Memory

Peek at saved memory (pr-code-quality-reviewer)

reviewed_at: 2026-10-27T11:34:22Z
review_event: COMMENT
top_themes:
  - cancelled startup failure classification can be masked by model configuration errors
files_reviewed:
  - actions/setup/js/handle_agent_failure.cjs
  - actions/setup/js/handle_agent_failure.test.cjs
comment_count: 1

Note

This comment is managed by comment memory.

Expand the saved memory block to view or edit the persistent context for this thread.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~2 AIC · ⌖ ~1 AIC · ⊞ 1.6K · ◷
_{Comment /review to run again}

[github-actions]

Review

One medium-severity classification regression needs attention; the inline comment explains how cancelled startup failures combined with model configuration errors can lose their startup diagnostic. The remaining changes and tests are otherwise covered by the existing behavior.

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~2 AIC · ⌖ ~1 AIC · ⊞ 1.6K
_{Comment /review to run again}

[github-actions]

Skills-Based Review 🧠

Applied /diagnosing-bugs — this is a clean, well-targeted fix.

📋 Analysis

Root cause match: The fix exactly matches the root cause in the linked issue (#72367): the cancellation exemption only covered collectorEmptyOutputCause === "missing_terminal_safe_output", missing the agent_startup_failure case when cancellation happens before the engine starts (e.g. during custom steps:). Extending the check to an array (["missing_terminal_safe_output", "agent_startup_failure"]) and renaming isCancelledMissingTerminalOutput → isCancelledEmptyOutput is a minimal, surgical change.

Consistency check: I traced all 5 usages of the renamed flag (lines 4238, 4282, 4503, 4505, 4510) plus downstream consumers (failureCategories via emptyOutputCause, buildFailureDiagnosticsContext's isGenericFailure check, and getFailedAgentDiagnostics({ startupFailure })). All remain correctly derived and unaffected by the rename — no stale references to the old name remain.

Regression coverage: The it.each parameterization is a textbook example of /tdd edge-case coverage — it symmetrically extends the cancellation-exemption tests, the agent-authored (non-corroborated) test, the mixed-output diagnostics-suppression test, and (importantly) the negative case: non-cancelled startup failures (success, failure, timed_out conclusions with agent_startup_failure reason) still correctly produce failure issues. This guards against over-broadly suppressing legitimate startup-failure reports.

No gaps found: No doc updates needed (the cancellation-exemption mechanism is an internal implementation detail, not part of the public failure-category reference table). No other files needed the same fix (empty_output_outcome.cjs only defines cause labels, not the cancellation exemption logic).

No actionable issues found — approving.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet50 · ~69 AIC · ⌖ ~16 AIC · ⊞ 10.2K
_{Comment /matt to run again}

[github-actions]

🎉 This pull request is included in a new release.

Release: v1.0.1