Repository navigation
Test ZIP extraction limits against high-compression archives - #75264
Conversation
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
|
β Design Decision Gate ποΈ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate ποΈOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
π§ Matt Pocock Skills Reviewer has completed the skills-based review. β
|
|
β Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
β PR Code Quality Reviewer completed the code quality review.
|
|
β PR Specification Reviewer completed successfully! PR Specification ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
β Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
There was a problem hiding this comment.
π’ Approval recommended
No active review issues are reported, and the change is limited to regression coverage for ZIP extraction-size handling.
No open issues π
What changed in this PR
Adds regression coverage for rejecting highly compressible ZIP archives whose uncompressed size exceeds the configured extraction limit.
Changes:
- Creates a highly compressible 2 MiB ZIP entry.
- Applies a total uncompressed-size limit below the entry size.
- Verifies extraction is rejected before creating destination files.
- Confirms the destination directory remains empty after rejection.
| File | Description |
|---|---|
pkg/βcli/βlogs_extract_zip_test.go |
Adds high-compression archive coverage for total-size validation and pre-extraction rejection. |
Review effort: Lite (auto)
|
π This pull request is included in a new release. Release: |
ZIP bombs can exhaust resources during log extraction. Add a highly compressible archive fixture to verify oversized uncompressed content is rejected before extraction.