Repository navigation
Add Koka as an option in formal-methods instructions - #75267
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
✅ PR Specification Reviewer completed successfully! PR Specification ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
There was a problem hiding this comment.
🟡 Changes recommended
An active documentation inconsistency remains: the bullet unconditionally requires TLA+ files even though Koka-only models may not contain them.
1 open issue
What changed in this PR
This pull request extends the formal-methods instructions to support Koka alongside TLA+/TLC, distinguishing type/effect checking from temporal model checking.
Changes:
- Adds Koka guidance for typed functional models, algebraic effects, and handlers.
- Documents compiler setup, relevant model files, bounded checks, and reproducible evidence.
- Preserves existing TLA+/TLC model-checking guidance.
| File | Description |
|---|---|
.github/aw/formal-methods.md |
Extends formal-methods instructions with Koka tooling, model inspection, bounded checks, and evidence requirements. |
Review effort: Lite (auto)
| when one exists. For Koka, read the `.kk` modules, effect declarations, | ||
| handlers, and associated tests instead of TLA+/TLC-specific files. |
|
🎉 This pull request is included in a new release. Release: |
Extend the formal-methods instructions with Koka alongside TLA+/TLC, preserving existing model-checking guidance.