[Feature request] Option to change background color for `showbinds`

[dase78]

It would be a nice feature to have a simple possibility for changing the background color for the showbinds command so it stands out a little bit more.

If you have set a lot of similar Bindings it works fine, but if you only have 2 or 3 it would be nice to make it a little more flashy.

I would think of something like:

set showbindsbg #......

I have no idea how complicated this would be because it goes/starts into theming. Perhaps it could also be done with Escape Sequences?

[joelim-work]

It should be possible but there are some some points to consider:

• The menu in the UI isn't used just for the showbinds menu, it is also used to display marks (mark-load and mark-remove commands), and also command line completions. So I think the style should be applied consistently for every type of menu.
• There needs to be a separate configuration for the header since it is displayed in bold by default, and users may wish to customize this further.
• The syntax of the configuration should be in escape sequence format, as it matches all the other fmt options and #RRGGBB format cannot support bold or other style attributes.
• I am not interested in allowing customization for individual columns, or separate styles for different menus - that level of granularity is probably too niche to be worth implementing. But I agree that there is value in customizing the style of the menu overall so that it can stand out more from the list of files in each pane.

Hopefully the following patch should work for you:

diff --git a/eval.go b/eval.go
index 7bbd687..10362c6 100644
--- a/eval.go
+++ b/eval.go
@@ -269,20 +269,24 @@ func (e *setExpr) eval(app *app, args []string) {
 			default:
 				app.ui.echoerr("info: should consist of 'size', 'time', 'atime', 'btime', 'ctime', 'perm', 'user', 'group' or 'custom' separated with colon")
 				return
 			}
 		}
 		gOpts.info = toks
 	case "infotimefmtnew":
 		gOpts.infotimefmtnew = e.val
 	case "infotimefmtold":
 		gOpts.infotimefmtold = e.val
+	case "menufmt":
+		gOpts.menufmt = e.val
+	case "menutitlefmt":
+		gOpts.menutitlefmt = e.val
 	case "numberfmt":
 		gOpts.numberfmt = e.val
 	case "period":
 		n, err := strconv.Atoi(e.val)
 		if err != nil {
 			app.ui.echoerrf("period: %s", err)
 			return
 		}
 		if n < 0 {
 			app.ui.echoerr("period: value should be a non-negative number")
diff --git a/opts.go b/opts.go
index 04bb529..d5d715d 100644
--- a/opts.go
+++ b/opts.go
@@ -68,20 +68,22 @@ var gOpts struct {
 	history          bool
 	icons            bool
 	ifs              string
 	ignorecase       bool
 	ignoredia        bool
 	incfilter        bool
 	incsearch        bool
 	info             []string
 	infotimefmtnew   string
 	infotimefmtold   string
+	menufmt          string
+	menutitlefmt     string
 	mouse            bool
 	number           bool
 	numberfmt        string
 	period           int
 	preserve         []string
 	preview          bool
 	previewer        string
 	promptfmt        string
 	ratios           []int
 	relativenumber   bool
@@ -224,20 +226,22 @@ func init() {
 	gOpts.history = true
 	gOpts.icons = false
 	gOpts.ifs = ""
 	gOpts.ignorecase = true
 	gOpts.ignoredia = true
 	gOpts.incfilter = false
 	gOpts.incsearch = false
 	gOpts.info = nil
 	gOpts.infotimefmtnew = "Jan _2 15:04"
 	gOpts.infotimefmtold = "Jan _2  2006"
+	gOpts.menufmt = "\033[0m"
+	gOpts.menutitlefmt = "\033[1m"
 	gOpts.mouse = false
 	gOpts.number = false
 	gOpts.numberfmt = "\033[33m"
 	gOpts.period = 0
 	gOpts.preserve = []string{"mode"}
 	gOpts.preview = true
 	gOpts.previewer = ""
 	gOpts.promptfmt = "\033[32;1m%u@%h\033[0m:\033[34;1m%d\033[0m\033[1m%f\033[0m"
 	gOpts.ratios = []int{1, 2, 3}
 	gOpts.relativenumber = false
diff --git a/ui.go b/ui.go
index 178ce29..6ca00b5 100644
--- a/ui.go
+++ b/ui.go
@@ -1147,25 +1147,24 @@ func (ui *ui) draw(nav *nav) {
 
 		lines = lines[:len(lines)-1]
 
 		ui.menuWin.h = len(lines) - 1
 		ui.menuWin.y = ui.wins[0].h - ui.menuWin.h
 
 		if gOpts.drawbox {
 			ui.menuWin.y += 2
 		}
 
-		ui.menuWin.printLine(ui.screen, 0, 0, st.Bold(true), lines[0])
+		ui.menuWin.printLine(ui.screen, 0, 0, parseEscapeSequence(gOpts.menutitlefmt), lines[0])
 
 		for i, line := range lines[1:] {
-			ui.menuWin.printLine(ui.screen, 0, i+1, st, "")
-			ui.menuWin.print(ui.screen, 0, i+1, st, line)
+			ui.menuWin.printLine(ui.screen, 0, i+1, parseEscapeSequence(gOpts.menufmt), line)
 		}
 	}
 
 	ui.screen.Show()
 }
 
 func findBinds(keys map[string]expr, prefix string) (binds map[string]expr, ok bool) {
 	binds = make(map[string]expr)
 	for key, expr := range keys {
 		if !strings.HasPrefix(key, prefix) {
@@ -1689,20 +1688,20 @@ func listMatches(screen tcell.Screen, matches []compMatch, selectedInd int) stri
 	ncol := max(wtot/wcol, 1)
 
 	b.WriteString("possible matches\n")
 
 	for i := 0; i < mlen; {
 		for j := 0; j < ncol && i < mlen; i, j = i+1, j+1 {
 			name := matches[i].name
 			w := runeSliceWidth([]rune(name))
 
 			if i == selectedInd {
-				fmt.Fprintf(&b, "\033[7m%s\033[0m%*s", name, wcol-w, "")
+				fmt.Fprintf(&b, "\033[7m%s\033[27m%*s", name, wcol-w, "")
 			} else {
 				fmt.Fprintf(&b, "%s%*s", name, wcol-w, "")
 			}
 		}
 		b.WriteByte('\n')
 	}
 
 	return b.String()
 }

[dase78]

Thank you for the fast response! I didn't see the points you made and agree totally.

As I myself cannot/do not patch, I can't report the function of the patch. My request was an absolute Would-be-nice-extra. So if it will be added in any future releases, I would be happy about - if not I would not worry about. THX anyway!

[joelim-work]

So for the most part it works fine, but there's still a caveat - the completion menu has an additional concept of being able to select an item, and the way a selected item is shown in the UI is by reversing the colors (i.e. \033[7m%s\033[0m). The \033[0m at the end will mean that the style will be reset, and the rest of the line will be regular instead of whatever the user defines the menu style to be. I can't think of a clean way to work around this, so I'll leave this for now.

[dase78]

Then let's best leave it, it's not worth the effort.

[joelim-work]

I managed to implement this after all: #2123

[dase78]

This looks great, thanks! Really looking forward to r38.