Enhance rename prompt

[rrveex]

Argument for rename to work like this:

map r rename       # original rename
map i rename start # place the cursor at the beginning
map a rename ext   # place the cursor on the last .
map w rename cw    # no original name in prompt

[joelim-work]

Hi @rrveex , thanks for your pull request!

I'm just wondering, if you just want to create some more convenient rename mappings for yourself, would it not be possible to achieve this entirely within configuration and without having to make changes to the code?

map i :rename; cmd-home
map a :rename; cmd-word-back; cmd-left  # hacky way to move to the last '.', but it should work for most cases
map w :rename; cmd-delete-home

On the other hand, if you actually want to add these enhancements so that it can be used by others, this would require more consideration as to whether it's worth adding in or not. There is also the possibility where other users might wish to add in their own variations of rename that are not already covered here, for example keeping the extension but deleting the stem (i.e. if the file to be renamed is foo.txt, then the command line will look like |.txt).

[rrveex]

should work for most cases

That's exactly what I'm not happy with.

whether it's worth adding in or not.

My thought was "it doesn't break anything so why not?". Actually it costs maintenance in the long run. So if most users are happy with "works in most cases", you're right, it's not worth adding and wasting time maintaining a bigger code base.

other users [...] add their own variations of rename

I should have opened an issue instead of a PR, sorry.

[joelim-work]

So just to be clear, I am not against your change - I am just cautious about introducing new features when there are possible alternatives. As you have said, every new feature adds to the maintenance cost.

Please feel free to open an issue, create a discussion or otherwise just reopen this pull request. I do acknowledge that currently lf has no built-in way to place the cursor at the extension, and if there is enough support from the community then I can see a possibility that this change can be accepted. In any case, the decision for that lies with the project owner, which is not me.

[gokcehan]

@rrveex @joelim-work There was indeed already a discussion about this in #279 and I had agreed to place the cursor at the extension by default so other commands can be easily defined but nobody sent a PR afterwards.

[rrveex]

@gokcehan There was indeed already a discussion about this in #279 and I had agreed to place the cursor at the extension by default so other commands can be easily defined but nobody sent a PR afterwards.

Reopened with cursor default on dot if there is an extension, at the end otherwise.

[gokcehan]

@rrveex Looks good, thanks for the patch.

[ilyagr]

Nice feature, thanks!