Support btime in sortby and info - #2042
Merged
Merged
Conversation
CatsDeservePets
marked this pull request as ready for review
July 15, 2025 20:27
joelim-work
reviewed
Jul 17, 2025
joelim-work
left a comment
joelim-work
left a comment
Contributor
There was a problem hiding this comment.
Thanks, looks good overall. I have one minor comment before it gets merged.
joelim-work
approved these changes
Jul 19, 2025
joelim-work
left a comment
joelim-work
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for the changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for
btime(birth time, i.e. file creation time):btimeoption toinfoandsortbymap sb :set sortby btime; set info btimenameandnatural)I initially tried implementing it myself using
addcustominfo. But turns out this was way to slow and not practical at all because I also had to check whether the date is in the current year and depending on that format the date to either matchinfotimefmtneworinfotimefmtold.Turns out the library we already use for
ctimealso supportsbtimewhich allowed the introduction of this feature with very little changes.