Clear error messages after a command runs successfully - #2117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From suggestion in #2021 (comment)
Currently the
app.ui.loadFileInfofunction is used calculate the file stat information, which is read when drawing the ruler. This function is supposed to be called when a new file is selected, but there are many times when this is called simply to clear error messages when a command runs successfully.This PR changes
ui.msgto store only messages (i.e. error messages generated internally or from theecho/echomsg/echoerrcommands), decoupling it from the file stat information, which will now be calculated on-demand when drawing the ruler. If there is a message, then it will be shown without calculating the file stat information at all.Also, most commands are interactive and should clear error messages after being executed. There are a few commands like
invert/unselect/tag-togglewhich should do this, and is fixed as part of this change.