fix: align completion matches containing terminal sequences - #2511
Merged
Conversation
joelim-work
changed the title
joelim-work
approved these changes
Apr 13, 2026
joelim-work
left a comment
joelim-work
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for the patch.
Contributor
|
FYI, this applies to any kind of completion match but probably the easiest way to reproduce it is to create a filename containing terminal sequences and then tab complete it (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the sanitized file name can have a different displayed size which needs to be handled the same as in win.print