fix: update stale previews when preload is enabled - #2567
Merged
Conversation
joelim-work
approved these changes
May 4, 2026
joelim-work
left a comment
joelim-work
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the bug fix.
This was an oversight by me, but yes when preload is enabled preloadChan should be used instead of previewChan when loading an image preview into the cache.
joelim-work
changed the title
preload is enabled
joelim-work
added a commit
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkReg detects external file modifications by comparing mtime to reg.loadTime, but pushes the resulting reload to previewChan. When using the preload option, the deferred regChan send in preview() checks if gOpts.preload + "preload" and silently drops the result, leaving the cache stale forever.
This fix now matches the other cases and refreshes the cached preview data when a file changed