Skip to content

Fix: use Lstat like copyAll - #2619

Merged
CatsDeservePets merged 1 commit into
gokcehan:masterfrom
valoq:symlink-write
Jun 14, 2026
Merged

Fix: use Lstat like copyAll#2619
CatsDeservePets merged 1 commit into
gokcehan:masterfrom
valoq:symlink-write

Conversation

@valoq

@valoq valoq commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Broken symlinks are silently overwritten on move, whcih can simply be avoided by switching to Lstat which is already used in copyAll anyway.

@CatsDeservePets CatsDeservePets left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@CatsDeservePets
CatsDeservePets merged commit 4ef4b73 into gokcehan:master Jun 14, 2026
32 checks passed
@CatsDeservePets CatsDeservePets added the fix Pull requests that fix existing behavior label Jun 14, 2026
@CatsDeservePets CatsDeservePets added this to the r42 milestone Jun 14, 2026
@CatsDeservePets

CatsDeservePets commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Fun fact, this is the thousandth closed pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Pull requests that fix existing behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants