Repository navigation
v0.96.2: Improve performance with larger collections & bugfixes - #101
Merged
Merged
Conversation
htkhiem
changed the title
Closed
Specifically all the path-unregister code. This commit also refactors the ArtistSongRow to use the new LRU cache bypass path.
To be executed sequentially there (and still not blocking main UI). This avoids Sqlite panics when scrolling through a big library whose album art cache had just been deleted from disk.
This was
linked to
issues
Aug 2, 2025
Bumps local DB version to 2.
And the skip-to-external-provider path when MPD album art downloading is disabled. And the "do not try again" check. I forgot to reimplement these during a previous refactor.
htkhiem
changed the title
and stop crashing whenever I breathe on it wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance improvements
A low default value should help with performance on larger libraries. In the future we can probably cheat GTK4 by dynamically adjusting the GridViews'
max-columnsproperty according to window width and height.A code path that bypasses the Stretto cache to load album art from disk into widgets have also been added. This fixes the hangup caused by the Stretto cache not admitting new textures. Performance isn't perfect yet with some stuttering when scrolling & album arts appearing very slowly (at least in debug build mode).
Relevant discussions, including links to important points in the GTK4 source code, can be found in #99.
Bugfixes