Skip to content

Do not run slow tests when the setup steps failed - #6752

Merged
albertvillanova merged 1 commit into
mainfrom
ci-drop-always-on-test-step
Aug 17, 2026
Merged

albertvillanova merged 1 commit into
mainfrom
ci-drop-always-on-test-step

Conversation

@albertvillanova

@albertvillanova albertvillanova commented Aug 14, 2026 •

Copy link
Copy Markdown
Member

This PR removes if: always() from the steps that run the slow tests.

Motivation

With if: always(), both jobs run the slow tests even when checkout, the virtual environment creation, or the dependency installation failed. The tests then fail for a reason that has nothing to do with the tests themselves, which is reported as a test failure and hides the actual setup error. Removing the condition makes the job stop at the step that broke.

The reporting steps keep if: always(), since they are meant to run whether the tests passed or failed.

Changes

  • Remove if: always() from the slow tests steps of the single GPU and multi GPU jobs

Note

Low Risk
CI workflow-only change with no application or runtime impact; improves failure signal clarity.

Overview
Slow tests no longer run after a failed setup in the single-GPU and multi-GPU jobs of .github/workflows/slow-tests.yml.

Those jobs previously used if: always() on the Run slow tests steps, so checkout, venv, or dependency install failures still triggered make slow_tests, producing misleading test failures. That condition is removed so the job stops at the first failing setup step. Generate Report steps still use if: always() so summaries can run when tests fail for real test reasons.

Reviewed by Cursor Bugbot for commit 1b136b1. Bugbot is set up for automated code reviews on this repo. Configure here.

@bot-ci-comment

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange that we added this in the first place, thanks!

@albertvillanova
albertvillanova merged commit 7c2f124 into main Aug 17, 2026
24 checks passed
@albertvillanova
albertvillanova deleted the ci-drop-always-on-test-step branch August 17, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants