Repository navigation
Do not run slow tests when the setup steps failed - #6752
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
approved these changes
Aug 14, 2026
qgallouedec
left a comment
Member
There was a problem hiding this comment.
strange that we added this in the first place, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
if: always()from the steps that run the slow tests.Motivation
With
if: always(), both jobs run the slow tests even when checkout, the virtual environment creation, or the dependency installation failed. The tests then fail for a reason that has nothing to do with the tests themselves, which is reported as a test failure and hides the actual setup error. Removing the condition makes the job stop at the step that broke.The reporting steps keep
if: always(), since they are meant to run whether the tests passed or failed.Changes
if: always()from the slow tests steps of the single GPU and multi GPU jobsNote
Low Risk
CI workflow-only change with no application or runtime impact; improves failure signal clarity.
Overview
Slow tests no longer run after a failed setup in the single-GPU and multi-GPU jobs of
.github/workflows/slow-tests.yml.Those jobs previously used
if: always()on the Run slow tests steps, so checkout, venv, or dependency install failures still triggeredmake slow_tests, producing misleading test failures. That condition is removed so the job stops at the first failing setup step. Generate Report steps still useif: always()so summaries can run when tests fail for real test reasons.Reviewed by Cursor Bugbot for commit 1b136b1. Bugbot is set up for automated code reviews on this repo. Configure here.