socket2: add back changefloatingmode and togglegroup events - #14089
Merged
Conversation
|
Hello and thank you for making a PR to Hyprland! Please check the PR Guidelines and make sure your PR follows them. If your code can be tested, please always add tests. See more here. beep boop, I'm just a bot. A real human will review your PR soon. |
|
Comparing the source code with the documented IPC events at https://wiki.hypr.land/IPC/, found that As far as I checked, all the other documented events are present in the codebase. It was commented out with the note |
vaxerski
reviewed
Jun 5, 2026
ErrorNoInternet
force-pushed
the
add-back-events
branch
from
June 6, 2026 18:24
be1f6ac to
2ce0ce9
Compare
vaxerski
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
#12890 nuked
changefloatingmodeandtogglegroupevents from IPC. add them back.fixes #13721
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
(i honestly have no idea if i did this right)
i didnt add an event for groups to EventBus because the old togglegroup events also didn't emit anything and i dont know if we'll ever use it internally
Is it ready for merging, or does it need work?
should be ready, tested and works