workspace: guard null monitor access on ws visibility check - #14119
Merged
Conversation
|
Hello and thank you for making a PR to Hyprland! Please check the PR Guidelines and make sure your PR follows them. If your code can be tested, please always add tests. See more here. beep boop, I'm just a bot. A real human will review your PR soon. |
vaxerski
approved these changes
Apr 22, 2026
crthpl
pushed a commit
to crthpl/Hyprland
that referenced
this pull request
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Workspace only holds a weak pointer to monitor, which can probably get destroyed at an inopportune time during the refocus checks when a layer surface is being unmapped. Should hopefully fix #14118 (if it doesn't move the crash further down the line lol)
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Not sure if the pointer management in workspace/inputmgr/layersurface is all halal especially during monitor removal situations, but can't really figure out if it can be done better. This should fix the crash at least.
Is it ready for merging, or does it need work?
Ready