hl.mata.lua: add string to NotificationOptions's icon param. - #14334
Merged
Conversation
erstarr
marked this pull request as ready for review
May 7, 2026 18:39
|
Hello and thank you for making a PR to Hyprland! Please check the PR Guidelines and make sure your PR follows them. If your code can be tested, please always add tests. See more here. beep boop, I'm just a bot. A real human will review your PR soon. |
vaxerski
approved these changes
May 7, 2026
Contributor
|
What is this? You can't make changes to a autogenerated file... Also, hl.meta.lua should probably be .gitignored. |
Member
it was just not committed since the last change
it could be |
Contributor
Author
|
#14336 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
title. that field is auto generated anyway, and is auto added every build since the generated file is tracked and is currently missing the possible string value. This PR adds that there so this file can stop appearing in changed files on every build
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
no
Is it ready for merging, or does it need work?
yes