lua: restrict package module loading to lua-only modules - #14526
Conversation
|
Hello and thank you for making a PR to Hyprland! Please check the PR Guidelines and make sure your PR follows them. If your code can be tested, please always add tests. See more here. beep boop, I'm just a bot. A real human will review your PR soon. |
|
Why? |
|
I just don't understand why.. |
|
This already broke my newly created Lua based config in the last patch release and for what? No reason given, no reason asked for in review, just merged? Hard to say with nobody saying anything at all, but this smells like an LLM generated "security" suggestion than nobody bothered to even review. There are lots of legitimate uses for loading C modules into Lua: |
|
Yeah fuck this. |
|
No reason was given for this change, and no notes about breaking compatibility were given. There is no security benefit either, as configs can already execute any system commands. This is just plain silly, and I really think this should be reverted. Please consider #14533 . |
|
Why was this made? At least some explanation would be nice because as of now this doesn't seem useful whatsoever and has already broken by setup :( |
Describe your PR, what does it fix/add?
Restricts lua module loading to lua-only modules.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
nope
Is it ready for merging, or does it need work?
ready