Skip to content

lua: restrict package module loading to lua-only modules - #14526

Merged
vaxerski merged 1 commit into
hyprwm:mainfrom
x1h0:lua-loading
May 13, 2026
Merged

lua: restrict package module loading to lua-only modules#14526
vaxerski merged 1 commit into
hyprwm:mainfrom
x1h0:lua-loading

Conversation

@x1h0

@x1h0 x1h0 commented May 13, 2026

Copy link
Copy Markdown
Contributor

Describe your PR, what does it fix/add?

Restricts lua module loading to lua-only modules.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

nope

Is it ready for merging, or does it need work?

ready

@github-actions

Copy link
Copy Markdown

Hello and thank you for making a PR to Hyprland!

Please check the PR Guidelines and make sure your PR follows them.
It will make the entire review process faster. :)

If your code can be tested, please always add tests. See more here.

beep boop, I'm just a bot. A real human will review your PR soon.

@vaxerski vaxerski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vaxerski
vaxerski merged commit 8643d5b into hyprwm:main May 13, 2026
13 of 14 checks passed
@darkwater

Copy link
Copy Markdown
Contributor

Why?

@ItsOhen

ItsOhen commented May 13, 2026

Copy link
Copy Markdown
Contributor

I just don't understand why..
And don't give me that "BRUH SECURITY!" crap.

@alerque

alerque commented May 14, 2026

Copy link
Copy Markdown

This already broke my newly created Lua based config in the last patch release and for what? No reason given, no reason asked for in review, just merged? Hard to say with nobody saying anything at all, but this smells like an LLM generated "security" suggestion than nobody bothered to even review. There are lots of legitimate uses for loading C modules into Lua: lpeg, luafilesystem, luasocket, and many others rely on C modules to power their functions that might have perfectly valid use cases for some people. And it works, so so what are you even trying to fix with this?

@Dregu

Dregu commented May 14, 2026

Copy link
Copy Markdown
Contributor

Yeah fuck this.

@CelDaemon

Copy link
Copy Markdown

No reason was given for this change, and no notes about breaking compatibility were given. There is no security benefit either, as configs can already execute any system commands. This is just plain silly, and I really think this should be reverted. Please consider #14533 .

@SergeyKasmy

Copy link
Copy Markdown
Contributor

Why was this made? At least some explanation would be nice because as of now this doesn't seem useful whatsoever and has already broken by setup :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants