fractionalscale: track if scale is known and send scales eagerly when known - #14798
Merged
Conversation
|
Hello and thank you for making a PR to Hyprland! Please check the PR Guidelines and make sure your PR follows them. If your code can be tested, please always add tests. See more here. beep boop, I'm just a bot. A real human will review your PR soon. |
Contributor
Author
|
Ran the keybinds tests locally after patching in #14846, seems like the failure was a flake. |
Member
|
yes some tests do a funny sometimes |
ItsOhen
pushed a commit
to ItsOhen/Hyprland
that referenced
this pull request
Jun 1, 2026
…agerly when known (hyprwm#14798)
Psilocybin78
pushed a commit
to Psilocybin78/Singularity-compositor
that referenced
this pull request
Jul 3, 2026
…agerly when known (hyprwm#14798)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No AI.
Describe your PR, what does it fix/add?
This tracks whether a fractional scale has been explicitly set for a surface or not, and if one has been set it sends it when requested in onGetFractionalScale even if the surface is currently unmapped. That shouldn't ever be true for top level window surfaces unless they've been unmapped, but it means subsurfaces of unmapped surfaces will get the same scale as their parent.
Layers spawned on a specific monitor have the scale/transform immediately set from that monitor. This doesn't change the behaviour if the monitor's scale changes before mapping the layers.
Subsurfaces inherit the scales and transforms of their parents on creation, if known. This seems reasonable to me but it's the part I'm least confident about.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I looked into the bug report around double/redundant scale events (#9126) and confirmed this this does not regress it.
kitty --debug-renderingat 0.55.2 and this commit:kitty-55.2.log
kitty-debug.log
Is it ready for merging, or does it need work?
Worth reviewing closely but I think it's ready.