window: fix wrong scale being applied after workspace rules change monitor - #14832
Merged
Conversation
|
Hello and thank you for making a PR to Hyprland! Please check the PR Guidelines and make sure your PR follows them. If your code can be tested, please always add tests. See more here. beep boop, I'm just a bot. A real human will review your PR soon. |
vaxerski
approved these changes
May 29, 2026
ItsOhen
pushed a commit
to ItsOhen/Hyprland
that referenced
this pull request
Jun 1, 2026
Psilocybin78
pushed a commit
to Psilocybin78/Singularity-compositor
that referenced
this pull request
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No AI.
Describe your PR, what does it fix/add?
Removes redundant surface scale and transform updates from mapWindow. The full tree of subsurfaces was being walked twice, and at the end the main surface was also being updated on its own. But PMONITOR wasn't being updated to the current monitor after applying workspace rules, so that last one was based on a stale monitor.
Fixes #14726
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Tested locally and confirmed the scale was only being sent to the surface once, with the correct value, whether or not the target workspace already exists. There are no returns in mapWindow() after onMap() is called so I think the call in onMap is safe to remove.
Is it ready for merging, or does it need work?
Ready.