Skip to content

fix tokens for xdg-desktop-portals - #15433

Merged
vaxerski merged 4 commits into
hyprwm:mainfrom
gulafaran:tokens2
Jul 17, 2026
Merged

fix tokens for xdg-desktop-portals#15433
vaxerski merged 4 commits into
hyprwm:mainfrom
gulafaran:tokens2

Conversation

@gulafaran

Copy link
Copy Markdown
Contributor

tokens are only removed once a window maps, so things like xdg-desktop-portal got the 1337 month duration token added and always first launch in the wrong workspace. check PINITIALWSTRACKING and if mode 1 just give them a 1 second token. like other code paths does.

tokens are only removed once a window maps, so things like
xdg-desktop-portal got the 1337 month duration token added and always
first launch in the wrong workspace. check PINITIALWSTRACKING and if
mode 1 just give them a 1 second token. like other code paths does.
@vaxerski

Copy link
Copy Markdown
Member

question is does 1 second make sense? I think the entire point here is to launch some (slow) app, switch away, and have it launch where we were. Maybe like 10 seconds?

@gulafaran

Copy link
Copy Markdown
Contributor Author

question is does 1 second make sense? I think the entire point here is to launch some (slow) app, switch away, and have it launch where we were. Maybe like 10 seconds?

fair point, 10 seconds seems reasonable for silly things like krita that takes eons, but is an eternity for like a terminal. but i guess it can always be tweaked in the future if required. il change it

increase the timeout to 10 seconds, slow launching things like krita is
above the 1 second we have now. if 10 seconds is to much it can always
be fine tuned lower later.
@wabarTM

wabarTM commented Jul 16, 2026

Copy link
Copy Markdown

maybe expose it as a variable under misc or quirks?

add initial_workspace_token_timeout as a config option to be able to set
the default timeout for the initial workspace tracking token.
@gulafaran

Copy link
Copy Markdown
Contributor Author

maybe expose it as a variable under misc or quirks?

yeah true, done.

@gulafaran

Copy link
Copy Markdown
Contributor Author

wiki PR hyprwm/hyprland-wiki#1596

Comment thread src/config/supplementary/executor/Executor.cpp Outdated
urgl, to much going on at the same time. TIMEOUT certainly makes more
sense for an timeout.

@vaxerski vaxerski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wiki mr please

@vaxerski
vaxerski merged commit 4afc273 into hyprwm:main Jul 17, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants