pointer-warp: fix forgetting enter serial - #15462
Merged
Merged
Conversation
|
Wow that's amazing, I love that. |
vaxerski
reviewed
Jul 17, 2026
Member
|
@codex review please |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e8d17b808
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Dregu
force-pushed
the
pointer-warp-serial
branch
from
July 17, 2026 16:05
8e8d17b to
00d00c6
Compare
vaxerski
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Fixes pointer-warp proto that stops working after a while because the proto uses the latest serial from pointer::enter for validation, but that serial was kept in a common fifo that actually gets cleared pretty fast. Now keeps enterSerial forever, or until the next enter at least. Actually probably many protocols rely on this being kept safe.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I have no idea if this box of serials the others are kept in makes any sense at all, I just extracted the enterSerial from it to be kept safe. I feel like technically many things should probably be validated only against the enterSerial, not a box of random ones, but I don't have all the details and don't want to get into it.
Relevant disco #14622
Reprod simply with random SDL3 demo with
SDL_WarpMouseInWindow(window, 200.0f, 200.0f);stuck in the middle. Initially window seems to lock pointer, but releases it after smashing asdf for a few seconds, which exhausts the serial buffer and forgets our enter serial.Is it ready for merging, or does it need work?
Ready, but maybe someone test the real games too (cs2 radial menu, patched minecraft inventory etc)