example: update hyprland.lua default springs - #15499
Conversation
|
Codeowners approval required for this PR: |
|
I'm against having the default The current default dampening is the critical dampening of the default mass and stiffness (i.e. no bounce) which practically makes it little different than a bezier curve anyway which, while it does do some extra steps, was a good default before 0.56 made it slower. Your MR sets the dampening below the critical value thus making it bouncy. Not a good default imo Simply making it faster to match the prev value is preferable. |
|
I think it's good that the example config has examples of many different features, like springs behaving like springs. It's not supposed to be used as is anyway, it's supposed to be kinda usable to open a terminal. |
I myself used the animation defaults all this time, and i can guarantee you that most people do too. Something not so bouncy will be best I think even if it must be bouncy to showcase the feature. If you think of it as the example config as and example config and not a default config; you're right of course. |
Animations got changed in 0.56.0 and then after release the default spring was updated in hyprwm/Hyprland#15499, but that has a bit of a bounce to it that we can get rid of by increasing the dampening just a little bit so that the animation is still quick.
|
W |
yes --------- Co-authored-by: Vaxry <vaxry@vaxry.net>
Describe your PR, what does it fix/add?
Since v0.56 springs changed a bit, so default windows animations are now slow. This PR fixes it
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
nope
Is it ready for merging, or does it need work?
ready