screenshare: fix toplevel capture missing software cursor - #15638
Merged
Conversation
Member
|
sorry @Dregu you aint on the vouch list dam so sad |
vaxerski
reviewed
Jul 28, 2026
vaxerski
approved these changes
Jul 30, 2026
vaxerski
left a comment
vaxerski
left a comment
Member
There was a problem hiding this comment.
better. Can the affected test?
Member
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 853f6c6472
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
|
I guess they dont care, classic. code looks good. |
vaxerski
pushed a commit
that referenced
this pull request
Aug 5, 2026
* screenshare: fix toplevel capture cursor * rename arguments to reflect purpose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Fixes software cursors missing from toplevel capture. The function that was supposed to be forced to draw cursors still failed when it thought forcing was unnecessary. It thought wrong, drawing cursor on toplevel capture is always necessary.
#15604
Fingers crossed...
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
It's kinda silly, but someone designed the first force flag to not always work, and I think they also have a point, what can you do...
Is it ready for merging, or does it need work?
Ready.