desktop: render IME above all desktop components - #15646
Conversation
|
@codex review please |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ecc832197
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
I would still argue that it's weird to draw popups on top of completely unrelated overlay layers, popups should just draw on top of whatever their parent surface is. If that parent is overlay, then the ime should be on top of it of course. |
|
correct, but at the moment it's not exactly possible to detemine that other than hacks like "keyboard focus" which doesn't have to be true technically I think |
|
@codex review pleae |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bb82ca889
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Thank You! Btw, I initially thought the screen locker I was using was broken under Hyprland, since it completely ignored all my input. It turned out that the IME popup was being covered by another layer. |
nvm I was wrong, we have 1-to-1 mapping to a wl_surface, but at any rate the current hyprland input stack is not made for this so no, not in this mr |
|
@codex review please |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
3 participants
Put IME popups above everything in the rendering and input stack.
Even on lockscreens, IME could be requested. Maybe the user wants to input some username. Etc.