Fix importbot + make runnable locally - #12999
Merged
Merged
Conversation
cdrini
commented
Jun 22, 2026
| def import_data(self, data, headers=None): | ||
| headers = {"Content-Type": "application/json", **(headers or {})} | ||
| return self._request("/api/import", method="POST", data=data, headers=headers).text | ||
| def import_data(self, data): |
Collaborator
Author
There was a problem hiding this comment.
This indenting issue made the method uncallable ; which has likely killed importbot since the deploy!
cdrini
commented
Jun 22, 2026
| if os.getenv("LOCAL_DEV"): | ||
| ol = OpenLibrary(base_url="http://localhost:8080") | ||
| ol.login("admin", "admin123") | ||
| ol.login("openlibrary@example.com", "admin123") |
Collaborator
Author
There was a problem hiding this comment.
A while back login via the /account/login API stopped working with username and requires email.
mekarpeles
added a commit
that referenced
this pull request
Jun 24, 2026
docs(ai/imports): update for PR #12999 β importbot now runnable locally
pull Bot
pushed a commit
to iAMX11/openlibrary
that referenced
this pull request
Jun 24, 2026
β¦ runnable locally - index.md: update manage-imports.py description + add compose.near-prod.yaml entry; mark internetarchive#7236 fixed - debugging.md: replace 'ImportBot does not run' limitation with how-to, including env vars, docker compose command, and dev account credentials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an indenting issue introduced by I believe copilot in #12902 .
Also:
Technical
Testing
Confirmed locally starts up and picks up items from
import_item.Screenshot
Stakeholders