Skip to content

chore(tests): replace deprecated BeautifulSoup findAll with find_all - #13046

Merged
RayBB merged 1 commit into
masterfrom
chore/bs4-findall-deprecation
Jun 25, 2026
Merged

chore(tests): replace deprecated BeautifulSoup findAll with find_all#13046
RayBB merged 1 commit into
masterfrom
chore/bs4-findall-deprecation

Conversation

@RayBB

@RayBB RayBB commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Switches from the deprecated method to in the home template tests, eliminating BeautifulSoup noise in test output.

@RayBB

RayBB commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

@Sanket17052006 can you give a review of this PR? It's a small one but fixes a little noise.

@Sanket17052006

Sanket17052006 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

BeautifulSoup's findAll gives a DeprecationWarning: Call to deprecated method findAll. (Replaced by find_all) -- Deprecated since version 4.0.0. on every call. This PR removes that noise from pytest output. No functional change!

Ran docker compose run --rm home pytest openlibrary/plugins/openlibrary/tests/test_home.py -v

  • master β€” 7 warnings (2 are findAll deprecation)
  • PR branch β€” 5 warnings (findAll noise gone)

I ran rg "findAll" --type py across the repo and these 2 calls in test_home.py are the only findAll usages (the other 2 in vendor/infogami/ are vendored deps, out of scope)
LGTM!

@RayBB
RayBB merged commit a0aa393 into master Jun 25, 2026
8 checks passed
@RayBB
RayBB deleted the chore/bs4-findall-deprecation branch June 25, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants