Skip to content

Remove redundant publishers feature flag - #13084

Merged
RayBB merged 1 commit into
internetarchive:masterfrom
Sanket17052006:remove-publishers-feature-flag
Jul 1, 2026
Merged

Remove redundant publishers feature flag#13084
RayBB merged 1 commit into
internetarchive:masterfrom
Sanket17052006:remove-publishers-feature-flag

Conversation

@Sanket17052006

Copy link
Copy Markdown
Contributor

Part of #12946

This PR removes the publishers feature flag since it's enabled across all environments.

Technical

  • Removed publishers: enabled from conf/openlibrary.yml.
  • Removed publishers field from pydantic-settings Features model in openlibrary/core/features.py.
  • Removed is_enabled() overrides from publishers and index classes in openlibrary/plugins/worksearch/publishers.py β€” parent delegate.page defaults to True, matching the always-on behavior.
  • Simplified openlibrary/templates/publishers/view.html and openlibrary/templates/type/edition/view.html by removing the "publishers" in ctx.features branches. The /publishers/<name> URL path is now the default β€” the old /search?publisher_facet=... fallback is deleted.
  • Removed obsolete i18n strings from messages.pot and cleaned up test fixtures in test_features.py.

Testing

  • make test-py-uv PYTEST_ARGS="openlibrary/tests/core/test_features.py"
  • Grepped for "publishers" in ctx.features and "publishers" in web.ctx.features β€” zero remaining

Screenshot

N/A

Stakeholders

@RayBB

@openlibrary-bot

Copy link
Copy Markdown
Collaborator

Thanks for the PR!

The linked issue hasn't been triaged yet β€” triage happens on Mondays and Fridays. There are currently 24 open non-draft PRs ahead of yours.

PR triage checklist (maintainers / Richy)
  • PR description β€” not empty; explains what the change does and how to verify it
  • References an issue β€” PR body contains a #NNN reference
    • Linked issue is triaged β€” has a Priority: * label (not just Needs: Triage)
    • Linked issue is assigned β€” has at least one assignee
  • Commit history clean β€” no WIP/fixup/conflict noise; commit messages are meaningful
  • CI passing β€” no failing check-runs
  • Test cases present β€” if the change touches substantive logic, test coverage exists or is explained
  • Proof of testing β€” PR body includes a description of what was tested, a screenshot, or a video

Note

This comment was automatically generated by PAM, Open Library's Project AI Manager. PAM provides status visibility, performs basic project management functions, and gives actionable feedback so contributors aren't left waiting.

@RayBB RayBB left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very fast and good work!

Put it on testing and it's going excellent.

I also did a search and feel very sure there are no other usages.

It's so nice we are cleaning up our feature flags!

@RayBB
RayBB merged commit 6af881c into internetarchive:master Jul 1, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants