Remove redundant publishers feature flag - #13084
Merged
RayBB merged 1 commit intoJul 1, 2026
Merged
Conversation
Collaborator
|
Thanks for the PR! The linked issue hasn't been triaged yet β triage happens on Mondays and Fridays. There are currently 24 open non-draft PRs ahead of yours. PR triage checklist (maintainers / Richy)
Note This comment was automatically generated by PAM, Open Library's Project AI Manager. PAM provides status visibility, performs basic project management functions, and gives actionable feedback so contributors aren't left waiting. |
RayBB
approved these changes
Jul 1, 2026
RayBB
left a comment
Collaborator
There was a problem hiding this comment.
Very fast and good work!
Put it on testing and it's going excellent.
I also did a search and feel very sure there are no other usages.
It's so nice we are cleaning up our feature flags!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12946
This PR removes the
publishersfeature flag since it'senabledacross all environments.Technical
publishers: enabledfromconf/openlibrary.yml.publishersfield from pydantic-settingsFeaturesmodel inopenlibrary/core/features.py.is_enabled()overrides frompublishersandindexclasses inopenlibrary/plugins/worksearch/publishers.pyβ parentdelegate.pagedefaults toTrue, matching the always-on behavior.openlibrary/templates/publishers/view.htmlandopenlibrary/templates/type/edition/view.htmlby removing the"publishers" in ctx.featuresbranches. The/publishers/<name>URL path is now the default β the old/search?publisher_facet=...fallback is deleted.messages.potand cleaned up test fixtures intest_features.py.Testing
make test-py-uv PYTEST_ARGS="openlibrary/tests/core/test_features.py""publishers" in ctx.featuresand"publishers" in web.ctx.featuresβ zero remainingScreenshot
N/A
Stakeholders
@RayBB