Fix author date precision matching - #13128
Merged
jimchamp merged 1 commit intoJul 10, 2026
Merged
Conversation
MakenRosa
force-pushed
the
fix/author-date-precision
branch
from
July 7, 2026 01:38
7c92943 to
bb5b5ce
Compare
Collaborator
|
Thanks for this contribution, @MakenRosa! Welcome to Open Library β this appears to be your first contribution. @jimchamp is assigned to this PR and currently has:
PR triage checklist (maintainers / Richy)
Note This comment was automatically generated by PAM, Open Library's Project AI Manager. PAM provides status visibility, performs basic project management functions, and gives actionable feedback so contributors aren't left waiting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13065
Fixes author date matching so two fully specified dates with different month/day values no longer match just because they share the same year. Year-only and partial-date comparisons still fall back to the existing year-based behavior for import tolerance.
Technical
YYYY-MM-DD,M/D/YYYY,day month year, andmonth day year.Testing
docker compose run --rm --no-deps -e PYTHONPATH=/openlibrary/vendor/infogami home python -m ruff check openlibrary/catalog/utils/__init__.py openlibrary/tests/catalog/test_utils.pydocker compose run --rm --no-deps -e PYTHONPATH=/openlibrary/vendor/infogami home python -m pytest openlibrary/tests/catalog/test_utils.py openlibrary/catalog/utils/tests/test_catalog_utils.py openlibrary/catalog/add_book/tests/test_load_book.py::TestImportAuthor::test_birth_and_death_date_match_is_on_year_strings -qdocker compose run --rm --no-deps -e PYTHONPATH=/openlibrary/vendor/infogami home python -m pytest openlibrary/catalog/add_book/tests/test_load_book.py -qScreenshot
N/A
Stakeholders
@jimchamp