fix(agentic): exclude openlibrary-bot from issue enrichment - #13166
Merged
Conversation
user.type != 'Bot' and the [bot]-suffix check do not catch openlibrary-bot -- its account type is "User", confirmed via the GitHub API. Add an explicit login check at both the workflow if: level and in the prompt's skip conditions. Fixes #13165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openlibrary-bot's GitHub accounttypeis"User", not"Bot"(confirmed viagh api users/openlibrary-bot -q '.type'), and its login doesn't end in[bot]. Both the workflow-levelif:gate and the prompt's documented skip conditions inissue_enrichment.yml/.mdrely on exactly those two signals — so an issue opened byopenlibrary-botis currently NOT excluded from enrichment, contrary to intent.Fixes #13165.
Fix
Adds an explicit
user.login != 'openlibrary-bot'check alongside the existing type/[bot]-suffix checks, at both the workflowif:level (cheap, structural) and in the prompt's documented skip conditions (so the reasoning stays correct if someone edits the trigger logic later without re-checking the YAML).Same fix already applied to the not-yet-merged PR auto-responder (#13164) before it merged, and to
pr-prereview.md(the source doc for the PR-side flow, in the privatepmPAM repo).Related
openlibrary-botcomments trigger "Needs: Response" labeling #13138 — prior instance of the general "ignore openlibrary-bot's own actions" problem classTesting
pre-commit runpasses on both changed files. Not independently verified against a live issue opened byopenlibrary-bot(would require the bot to actually open one) — theif:logic change is a straightforward boolean addition, low risk.