fix: keep catalog export links in a row below floated columns (author page) - #13219
Merged
lokesh merged 2 commits intoJul 30, 2026
Merged
Conversation
The exports bar ("Download catalog record: RDF / JSON") rendered over the
sidebar at the top right of author pages. internetarchive#13091 replaced its `float: right`
with `display: flex`, which left it as an in-flow block among the floated
`.contentTwothird` / `.contentOnethird` columns it follows, so it was laid
out beside them and squeezed to ~38px wide.
Make it a block-level, right-aligned text row that clears the floats, so it
sits below all columns on both author and book pages.
Closes internetarchive#13218
Collaborator
Author
|
@Sadashii Small UI bug fix. If you have a sec, please review. |
lokesh
added
Needs: Review
Collaborator
|
Been bugging me too for quite a while. LGTM! |
github-actions
Bot
added
the
Needs: Response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13218
Problem
On author pages the "Download catalog record" bar rendered at the top right, squeezed to ~38px wide over the sidebar, instead of as a row at the bottom.
#13091 replaced the bar's
float: rightwithdisplay: flex. The bar follows two floated columns (.contentTwothird/.contentOnethird,float: leftat ≥960px), and an in-flow block is laid out beside floats rather than below them.Fix
clear: bothdrops the bar below the floated columns. A block formatting context (flow-root,overflow: hidden,display: flex) is not an alternative — a BFC box gets narrowed to fit beside floats, which is the bug itself.text-align: rightreplaces the flex row since this is one line of text, not a layout row. #13091's spacing is unchanged, so #13090 stays fixed.Testing
/authors/OL648Aand/books/OL755M: full-width, right-aligned, below both columns, inside#contentBodywith no overlap or overflow. Wraps in narrow containers. Below 960px the columns aren't floated, soclearis a no-op.Before / after:
FIXED:
