Fix on-call notification workflow - #13375
Merged
Merged
Conversation
The GitHub Slack action is now called from within the on-call notification workflow directly.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the scheduled on-call notification GitHub Actions workflow to post directly to Slack (via slackapi/slack-github-action) instead of delegating to a reusable notify_slack workflow, and adjusts the on-call roster ordering used to compute lead/backup.
Changes:
- Inline Slack posting into
.github/workflows/pm_on_call_notification.ymland gate it via a step-levelif. - Remove the now-unused reusable workflow
.github/workflows/notify_slack.yml. - Update
.github/workflows/config/pm_config.jsonpersonnel ordering to match the intended rotation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/pm_on_call_notification.yml | Posts to Slack directly using slackapi/slack-github-action@v4.0.0 when the generated message is non-empty. |
| .github/workflows/notify_slack.yml | Deletes the reusable Slack publishing workflow (verified no remaining references). |
| .github/workflows/config/pm_config.json | Updates on-call personnel ordering used by the workflow’s rotation logic. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #13168
Updates on-call notification workflow to call the Slack action directly.
Removes
notify_slackworkflow.Updates configuration to match our current on-call schedule.
Technical
Testing
Screenshot
Stakeholders