Skip to content

fix: add FastAPI route alias for .json note POSTs to match legacy web… - #13382

Merged
RayBB merged 1 commit into
internetarchive:masterfrom
Sanket17052006:fix/notes-json-route-alias
Aug 20, 2026
Merged

fix: add FastAPI route alias for .json note POSTs to match legacy web…#13382
RayBB merged 1 commit into
internetarchive:masterfrom
Sanket17052006:fix/notes-json-route-alias

Conversation

@Sanket17052006

Copy link
Copy Markdown
Contributor

This PR adds the .json route to /works/OL{id}W/notes as #12007 migrated the notes endpoint to FastAPI and registered
POST /works/OL{id}W/notes without the .json alias, but the frontend (NotesModal + work-page
modal, modals/index.js) still POSTs to /works/OL{id}W/notes.json.

Technical

  • Adds the .json route alias to the existing booknotes_post handler.

Testing

  • Regression test added in test_booknotes.py: add + remove via POST /works/OL123W/notes.json

Screenshot

N/A

Stakeholders

@RayBB

@RayBB RayBB left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding this and being so proactive opening a PR for it!

@RayBB RayBB self-assigned this Aug 20, 2026
@github-project-automation github-project-automation Bot moved this to Waiting Review/Merge from Staff in Ray's Project Aug 20, 2026
@RayBB
RayBB merged commit c79e745 into internetarchive:master Aug 20, 2026
5 of 7 checks passed
@github-project-automation github-project-automation Bot moved this from Waiting Review/Merge from Staff to Done in Ray's Project Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants