Skip to content

Fixed: After upgrading Gradle, we were unable to upload the AAB because APK splitting was enabled. - #4274

Merged
kelson42 merged 1 commit into
mainfrom
Fixes#4273
Apr 3, 2025
Merged

Fixed: After upgrading Gradle, we were unable to upload the AAB because APK splitting was enabled.#4274
kelson42 merged 1 commit into
mainfrom
Fixes#4273

Conversation

@MohitMaliFtechiz

Copy link
Copy Markdown
Collaborator

Fixes #4273

  • ABI splitting is now enabled only when needed (i.e., when building an APK) through an environment variable (APK_BUILD). By default, ABI splitting remains disabled for aab.
  • Refactored the workflow to align with this change.
  • Updated the README to document this change, ensuring that everyone is aware of this feature.

…se APK splitting was enabled.

* ABI splitting is now enabled only when needed (i.e., when building an APK) through an environment variable (APK_BUILD). By default, ABI splitting remains disabled.
* Refactored the workflow to align with this change.
* Updated the README to document this change, ensuring that everyone is aware of this feature.
@codecov

codecov Bot commented Apr 3, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.26%. Comparing base (4236be8) to head (53e6cf3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4274      +/-   ##
============================================
+ Coverage     58.90%   59.26%   +0.36%     
- Complexity     1588     1608      +20     
============================================
  Files           342      342              
  Lines         15099    15099              
  Branches       1904     1904              
============================================
+ Hits           8894     8949      +55     
+ Misses         4912     4849      -63     
- Partials       1293     1301       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kelson42
kelson42 merged commit bb25fca into main Apr 3, 2025
@kelson42
kelson42 deleted the Fixes#4273 branch April 3, 2025 10:51
@MohitMaliFtechiz

MohitMaliFtechiz commented Apr 3, 2025

Copy link
Copy Markdown
Collaborator Author

@IzzySoft This is a new feature we have introduced, so in the next release, please add the APK_BUILD=true env variable in your workflow so that it enables the ABI splitting. Otherwise, your workflow will fail because of by default, ABI splitting is disabled. See for more reference https://github.com/kiwix/kiwix-android?tab=readme-ov-file#abi-splitting-for-apks.

@IzzySoft

IzzySoft commented Apr 3, 2025

Copy link
Copy Markdown
Contributor

Thanks @MohitMaliFtechiz – added a FIXME note to the recipe file on our end.

@MohitMaliFtechiz MohitMaliFtechiz mentioned this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After upgrading gradle we are unable to upload aab because APKs splitting is enabled.

4 participants