Using the server address provided by libkiwix. - #4487
Merged
Conversation
* Using the server address provided by libkiwix instead of the custom one(Created in Android). * Upgraded to libkiwix `2.4.0`.
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (40.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #4487 +/- ##
============================================
- Coverage 58.49% 58.21% -0.29%
+ Complexity 1464 1460 -4
============================================
Files 327 327
Lines 17057 17063 +6
Branches 2115 2116 +1
============================================
- Hits 9978 9933 -45
- Misses 5676 5727 +51
Partials 1403 1403 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Seems we still have a problem with the CI! |
Collaborator
Author
|
@kelson42 Now, CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4484
2.4.0.InitialDownloadTest, andDownloadTestwere failing on API level 35.screen-20251112-225231.mp4