Fix webhook certificate regeneration on Helm upgrades - #4581
Merged
Conversation
k8s-ci-robot
added
approved
Collaborator
Author
|
/retest |
zac-nixon
approved these changes
Feb 12, 2026
Collaborator
|
/lgtm |
k8s-ci-robot
added
the
lgtm
wweiwei-li
approved these changes
Feb 13, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shraddhabang, wweiwei-li, zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description
In AWS Load Balancer Controller v3.0.0+, webhook TLS certificates are regenerated on every Helm upgrade, causing webhook verification failures and deployment issues. Users experience TLS verification errors and can cause temporary service disruption during upgrades until the new cert is generated.
Root Cause
The
keepTLSSecretparameter and associated certificate reuse logic were removed in v3.0.0 to resolve conflicts with cert-manager (#4348). However, this introduced a regression where certificates are always regenerated during Helm upgrades, even when cert-manager is not being used.Timeline:
keepTLSSecretdefaulted totrue(unintended but worked)keepTLSSecretparameter completely removed → always regenerate certificatesReintroduce the
keepTLSSecretparameter with improved logic that maintains cert-manager compatibility. The default value of this flag is false as it was originally intended.Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯