Skip to content

add ingress webhook validator selectors to helm chart - #4626

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
zac-nixon:ing/ns-selector
Mar 16, 2026
Merged

add ingress webhook validator selectors to helm chart#4626
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
zac-nixon:ing/ns-selector

Conversation

@zac-nixon

Copy link
Copy Markdown
Collaborator

Issue

#4614

Description

Adds object and namespace selectors to the Ingress Validator webhook. Similar to the other webhooks we maintain. Also adds a Failure Policy to the Ingress Validator webhook, just like our other webhooks.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🀯

  • Backfilled missing tests for code in same general area πŸŽ‰
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 16, 2026
@shuqz

shuqz commented Mar 16, 2026

Copy link
Copy Markdown
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2026
@k8s-ci-robot
k8s-ci-robot merged commit f614876 into kubernetes-sigs:main Mar 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants